[0.11] gst-plugins-bad: kate: fix race condition on PAUSED-> READY state change

Wim Taymans wtay at kemper.freedesktop.org
Tue Oct 4 04:27:57 PDT 2011


Module: gst-plugins-bad
Branch: 0.11
Commit: 12bb47343d970d7c4ceb625e30351fbba8db2c3e
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=12bb47343d970d7c4ceb625e30351fbba8db2c3e

Author: Vincent Penquerc'h <ogg.k.ogg.k at googlemail.com>
Date:   Sat Oct  1 14:30:07 2011 +0100

kate: fix race condition on PAUSED->READY state change

https://bugzilla.gnome.org/show_bug.cgi?id=660630

---

 ext/kate/gstkatetiger.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/ext/kate/gstkatetiger.c b/ext/kate/gstkatetiger.c
index 41da4db..ca02c91 100644
--- a/ext/kate/gstkatetiger.c
+++ b/ext/kate/gstkatetiger.c
@@ -571,6 +571,12 @@ gst_kate_tiger_kate_chain (GstPad * pad, GstBuffer * buf)
   GST_LOG_OBJECT (tiger, "Got kate buffer, caps %" GST_PTR_FORMAT,
       GST_BUFFER_CAPS (buf));
 
+  /* Now that we have the lock, check if we're flushing */
+  if (tiger->decoder.kate_flushing) {
+    GST_DEBUG_OBJECT (tiger, "Flushing, disregarding buffer");
+    goto done;
+  }
+
   /* Unfortunately, it can happen that the start of the stream is not sent,
      for instance if there's a stream selector upstream, which is switched
      from another Kate stream. If this happens, then we can fallback on the
@@ -663,6 +669,7 @@ gst_kate_tiger_kate_chain (GstPad * pad, GstBuffer * buf)
     }
   }
 
+done:
   GST_KATE_TIGER_MUTEX_UNLOCK (tiger);
 
   gst_object_unref (tiger);



More information about the gstreamer-commits mailing list