gst-plugins-base: tests: vorbisdec: remove empty header buffer check

Mark Nauwelaerts mnauw at kemper.freedesktop.org
Sat Oct 8 11:53:16 PDT 2011


Module: gst-plugins-base
Branch: master
Commit: 12b54cccd153d64025aa3b7ae3eb1a092f7eceda
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=12b54cccd153d64025aa3b7ae3eb1a092f7eceda

Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Sat Oct  8 20:14:27 2011 +0200

tests: vorbisdec: remove empty header buffer check

... as empty buffers are discarded, and header buffers are now
also optionally retrieved from caps anyway.

---

 tests/check/elements/vorbisdec.c |   37 -------------------------------------
 1 files changed, 0 insertions(+), 37 deletions(-)

diff --git a/tests/check/elements/vorbisdec.c b/tests/check/elements/vorbisdec.c
index 29e3cd5..8a9281a 100644
--- a/tests/check/elements/vorbisdec.c
+++ b/tests/check/elements/vorbisdec.c
@@ -94,42 +94,6 @@ cleanup_vorbisdec (GstElement * vorbisdec)
   gst_check_teardown_element (vorbisdec);
 }
 
-GST_START_TEST (test_empty_identification_header)
-{
-  GstElement *vorbisdec;
-  GstBuffer *inbuffer;
-  GstBus *bus;
-  GstMessage *message;
-
-  vorbisdec = setup_vorbisdec ();
-  bus = gst_bus_new ();
-
-  fail_unless (gst_element_set_state (vorbisdec,
-          GST_STATE_PLAYING) == GST_STATE_CHANGE_SUCCESS,
-      "could not set to playing");
-
-  inbuffer = gst_buffer_new_and_alloc (0);
-  ASSERT_BUFFER_REFCOUNT (inbuffer, "inbuffer", 1);
-
-  /* set a bus here so we avoid getting state change messages */
-  gst_element_set_bus (vorbisdec, bus);
-
-  fail_unless_equals_int (gst_pad_push (mysrcpad, inbuffer), GST_FLOW_ERROR);
-  /* ... but it ends up being collected on the global buffer list */
-  fail_unless_equals_int (g_list_length (buffers), 0);
-
-  fail_if ((message = gst_bus_pop (bus)) == NULL);
-  fail_unless_message_error (message, STREAM, DECODE);
-  gst_message_unref (message);
-  gst_element_set_bus (vorbisdec, NULL);
-
-  /* cleanup */
-  gst_object_unref (GST_OBJECT (bus));
-  cleanup_vorbisdec (vorbisdec);
-}
-
-GST_END_TEST;
-
 /* FIXME: also tests comment header */
 GST_START_TEST (test_identification_header)
 {
@@ -329,7 +293,6 @@ vorbisdec_suite (void)
   TCase *tc_chain = tcase_create ("general");
 
   suite_add_tcase (s, tc_chain);
-  tcase_add_test (tc_chain, test_empty_identification_header);
   tcase_add_test (tc_chain, test_identification_header);
   tcase_add_test (tc_chain, test_empty_vorbis_packet);
 



More information about the gstreamer-commits mailing list