[0.11] gst-plugins-good: alpha: Don't use start() vmethod

Edward Hervey bilboed at kemper.freedesktop.org
Tue Oct 11 02:06:35 PDT 2011


Module: gst-plugins-good
Branch: 0.11
Commit: 919dcf405d0c190235c4f60e779fb4a6e1427477
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=919dcf405d0c190235c4f60e779fb4a6e1427477

Author: Edward Hervey <edward.hervey at collabora.co.uk>
Date:   Mon Oct 10 17:41:10 2011 +0200

alpha: Don't use start() vmethod

The only thing we're doing is initializing parameters ...
* which won't work because we don't have upstream/downstream caps
* which will be initialized when ::set_caps() is called

---

 gst/alpha/gstalpha.c |   14 --------------
 1 files changed, 0 insertions(+), 14 deletions(-)

diff --git a/gst/alpha/gstalpha.c b/gst/alpha/gstalpha.c
index 4ef2754..3b6ce3a 100644
--- a/gst/alpha/gstalpha.c
+++ b/gst/alpha/gstalpha.c
@@ -156,7 +156,6 @@ GST_STATIC_CAPS (GST_VIDEO_CAPS_MAKE ("{ AYUV, ARGB, BGRA, ABGR, RGBA }"));
   g_static_mutex_unlock (&alpha->lock); \
 } G_STMT_END
 
-static gboolean gst_alpha_start (GstBaseTransform * trans);
 static gboolean gst_alpha_get_unit_size (GstBaseTransform * btrans,
     GstCaps * caps, gsize * size);
 static GstCaps *gst_alpha_transform_caps (GstBaseTransform * btrans,
@@ -270,7 +269,6 @@ gst_alpha_class_init (GstAlphaClass * klass)
   gst_element_class_add_pad_template (gstelement_class,
       gst_static_pad_template_get (&gst_alpha_src_template));
 
-  btrans_class->start = GST_DEBUG_FUNCPTR (gst_alpha_start);
   btrans_class->transform = GST_DEBUG_FUNCPTR (gst_alpha_transform);
   btrans_class->before_transform =
       GST_DEBUG_FUNCPTR (gst_alpha_before_transform);
@@ -2562,18 +2560,6 @@ gst_alpha_set_process_function (GstAlpha * alpha)
   return alpha->process != NULL;
 }
 
-static gboolean
-gst_alpha_start (GstBaseTransform * btrans)
-{
-  GstAlpha *alpha = GST_ALPHA (btrans);
-
-  GST_ALPHA_LOCK (alpha);
-  gst_alpha_init_params (alpha);
-  GST_ALPHA_UNLOCK (alpha);
-
-  return TRUE;
-}
-
 static void
 gst_alpha_before_transform (GstBaseTransform * btrans, GstBuffer * buf)
 {



More information about the gstreamer-commits mailing list