gstreamer: basetransform: send delayed events earlier

Sebastian Dröge slomo at kemper.freedesktop.org
Tue Sep 27 03:00:37 PDT 2011


Module: gstreamer
Branch: master
Commit: 01172b8126df795eda19a3fe6646d833f8c2c230
URL:    http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=01172b8126df795eda19a3fe6646d833f8c2c230

Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Mon Sep 26 19:52:13 2011 +0100

basetransform: send delayed events earlier

Some elements (such as videorate) might push buffers early,
for instance in in transform_ip. We want events (and in particular
any NEWSEGMENT event) to be pushed before that.

This fixes transmageddon wedging on converting a file starting
with a non zero offset to Ogg.

https://bugzilla.gnome.org/show_bug.cgi?id=660165

---

 libs/gst/base/gstbasetransform.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/libs/gst/base/gstbasetransform.c b/libs/gst/base/gstbasetransform.c
index 3d77e74..7ccfb04 100644
--- a/libs/gst/base/gstbasetransform.c
+++ b/libs/gst/base/gstbasetransform.c
@@ -2517,6 +2517,8 @@ gst_base_transform_chain (GstPad * pad, GstBuffer * buffer)
   if (klass->before_transform)
     klass->before_transform (trans, buffer);
 
+  gst_base_transform_send_delayed_events (trans);
+
   /* protect transform method and concurrent buffer alloc */
   GST_BASE_TRANSFORM_LOCK (trans);
   ret = gst_base_transform_handle_buffer (trans, buffer, &outbuf);
@@ -2554,8 +2556,6 @@ gst_base_transform_chain (GstPad * pad, GstBuffer * buffer)
       }
       trans->priv->processed++;
 
-      gst_base_transform_send_delayed_events (trans);
-
       ret = gst_pad_push (trans->srcpad, outbuf);
     } else {
       gst_buffer_unref (outbuf);



More information about the gstreamer-commits mailing list