[0.11] gstreamer: segment: don't use duration in clipping
Wim Taymans
wtay at kemper.freedesktop.org
Mon Feb 20 05:45:19 PST 2012
Module: gstreamer
Branch: 0.11
Commit: afba547722c94519fc38bc4106a3e029848f8d28
URL: http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=afba547722c94519fc38bc4106a3e029848f8d28
Author: Wim Taymans <wim.taymans at collabora.co.uk>
Date: Mon Feb 20 14:29:30 2012 +0100
segment: don't use duration in clipping
Don't use the duration in the segment for calculating clipping values.
The duration is expressed in stream time and clipping is done on unrelated
timestamp values.
This used to be interesting for elements that used the segment structure to
implement seeking because then they would use stream-time for the segment
start/stop values and the duration could be used as a fallback when the stop
position was not set. Now that the complete segment event is passed between
elements we cannot do this anymore because some elements might store the
duration and start/stop values with different time bases in the segment.
---
gst/gstsegment.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/gst/gstsegment.c b/gst/gstsegment.c
index 64aa09d..a3b57b8 100644
--- a/gst/gstsegment.c
+++ b/gst/gstsegment.c
@@ -562,9 +562,6 @@ gst_segment_clip (const GstSegment * segment, GstFormat format, guint64 start,
*clip_stop = stop;
else
*clip_stop = MIN (stop, segment->stop);
-
- if (segment->duration != -1 && *clip_stop != -1)
- *clip_stop = MIN (*clip_stop, segment->duration);
}
return TRUE;
More information about the gstreamer-commits
mailing list