gst-plugins-good: flacenc: remove post-port bogus _unref

Mark Nauwelaerts mnauw at kemper.freedesktop.org
Wed Feb 22 09:05:28 PST 2012


Module: gst-plugins-good
Branch: master
Commit: 38516ad367128d83f9e156529018adb4433cd328
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=38516ad367128d83f9e156529018adb4433cd328

Author: Mark Nauwelaerts <mark.nauwelaerts at collabora.co.uk>
Date:   Wed Feb 22 18:02:27 2012 +0100

flacenc: remove post-port bogus _unref

---

 ext/flac/gstflacenc.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/ext/flac/gstflacenc.c b/ext/flac/gstflacenc.c
index 6a7e1c0..c2eb333 100644
--- a/ext/flac/gstflacenc.c
+++ b/ext/flac/gstflacenc.c
@@ -814,7 +814,6 @@ gst_flac_enc_set_format (GstAudioEncoder * enc, GstAudioInfo * info)
 encoder_already_initialized:
   {
     g_warning ("flac already initialized -- fixme allow this");
-    gst_object_unref (flacenc);
     return FALSE;
   }
 setting_src_caps_failed:
@@ -822,14 +821,12 @@ setting_src_caps_failed:
     GST_DEBUG_OBJECT (flacenc,
         "Couldn't set caps on source pad: %" GST_PTR_FORMAT, caps);
     gst_caps_unref (caps);
-    gst_object_unref (flacenc);
     return FALSE;
   }
 failed_to_initialize:
   {
     GST_ELEMENT_ERROR (flacenc, LIBRARY, INIT, (NULL),
         ("could not initialize encoder (wrong parameters?)"));
-    gst_object_unref (flacenc);
     return FALSE;
   }
 }



More information about the gstreamer-commits mailing list