gst-plugins-good: matroska: do not leak attachment buffers

Vincent Penquerc'h vincent at kemper.freedesktop.org
Thu Jan 12 06:21:51 PST 2012


Module: gst-plugins-good
Branch: master
Commit: f04d812719f5622057df5aa2a74d430d85c37315
URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=f04d812719f5622057df5aa2a74d430d85c37315

Author: Vincent Penquerc'h <vincent.penquerch at collabora.co.uk>
Date:   Thu Jan 12 14:19:22 2012 +0000

matroska: do not leak attachment buffers

---

 gst/matroska/matroska-read-common.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/gst/matroska/matroska-read-common.c b/gst/matroska/matroska-read-common.c
index 188dea9..d2c2bea 100644
--- a/gst/matroska/matroska-read-common.c
+++ b/gst/matroska/matroska-read-common.c
@@ -633,6 +633,9 @@ gst_matroska_read_common_parse_attached_file (GstMatroskaReadCommon * common,
     else
       gst_tag_list_add (taglist, GST_TAG_MERGE_APPEND, GST_TAG_ATTACHMENT,
           tagbuffer, NULL);
+
+    /* the tag list adds it own ref */
+    gst_buffer_unref (tagbuffer);
   }
 
   g_free (filename);



More information about the gstreamer-commits mailing list