[gst-devel] Re: [gst-cvs] thomasvs gst-plugins: gst-plugins/gst/videotestsrc/

[Ronald Bultje]

Hey Thomas,

On Sat, 2003-05-10 at 19:37, Thomas Vander Stichele wrote:
> @@ -269,7 +269,8 @@
>  		"height",GST_PROPS_INT_RANGE(16,4096));
>    }
>  
> -  return gst_caps_intersect(caps1,caps2);
> +  /* ref intersection and return it */
> +  return gst_caps_ref (gst_caps_intersect(caps1,caps2));
>  }
>  
>  static void

This looks wrong to me. You're adding a reference but not actually
keeping the variable for inside use (i.e. the outcome of
gst_caps_intersect()). This looks like a potential memleak to me.

Ronald