[gst-devel] 2 things
jmoutte at electronic-group.com
Tue Nov 25 11:33:04 CET 2003
I will try to observe those comments and apply it in ximagesink and
Could you please also explain me what have you done with endianness
things and G_INT_FROM_BE things... ?
On Tue, 2003-11-25 at 15:56, in7y118 at public.uni-hamburg.de wrote:
> 2 things I've noticed that probably are important for you coders. The
> important one first:
> 1) GST_DEBUG ("cpas: %s", gst_caps_to_string (some_caps)); as used in the code
> very often is a memory leak. The string returned by gst_caps_to_string must be
> freed after use.
> If that continues I think it should be renamed it to gst_caps_copy_to_string
> (caps) or even use gst_caps_to_string (some_caps, &string) to get around you
> accidentally not freeing the string.
> 2) Caps provided to a link function are currently not checked against the caps
> returned by the get_caps function. So make sure to check that they are
> correct. ximagesink did not check that.
> This SF.net email is sponsored by: SF.net Giveback Program.
> Does SourceForge.net help you be more productive? Does it
> help you create better code? SHARE THE LOVE, and help us help
> YOU! Click Here: http://sourceforge.net/donate/
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
Julien MOUTTE - jmoutte at electronic-group.com
ELECTRONIC GROUP INTERACTIVE - www.electronic-group.com
World Trade Center, Moll de BARCELONA
Edificio Norte 4 Planta
08039 BARCELONA SPAIN
Tel : +34 93600 23 23 Fax : +34 93600 23 10
More information about the gstreamer-devel