[gst-devel] Re: [gst-cvs] ds gst-plugins: gst-plugins/ gst-plugins/ext/ffmpeg/ gst-plugins/ext/mad/ gst-plugins/gst/audioconvert/ gst-plugins/gst/audioscale/ gst-plugins/gst/videofilter/ gst-plugins/gst/videoscale/ gst-plugins/sys/ximage/

[Ronald Bultje]

Hi,

On Wed, 2003-12-31 at 09:02, David Schleef wrote:
> Log message:
> Negotiation fixes.
[..]
>     ext/ffmpeg      : gstffmpegcolorspace.c

those fixes broke ffcolorspace, again, for the third time in a few
weeks. Aah!

> -  /* and our own template of course */
> -  ourcaps = gst_caps_copy (gst_pad_get_pad_template_caps (pad));
> +    gst_structure_set_name (structure,"video/x-raw-yuv");
> +    gst_structure_remove_field (structure,"format");
> +    gst_structure_remove_field (structure,"endianness");
> +    gst_structure_remove_field (structure,"depth");
> +    gst_structure_remove_field (structure,"bpp");
> +    gst_structure_remove_field (structure,"red_mask");
> +    gst_structure_remove_field (structure,"green_mask");
> +    gst_structure_remove_field (structure,"blue_mask");
> +  }

? YUV? How about RGB? 
 
> +  if (space->passthru) {
> +    gst_pad_push (space->srcpad, data);
> +    return;
> +  }

This is handled a few lines lower in this function, so this isn't really
needed.

In general: did you test ffcolorspace? I've tried to make it as
functional as possible, having it working in encoding and decoding
pipelines. At least the encoding is broken now.

To reproduce:

gst-launch mplex format=9 name=mux ! fakesink { filesrc
location=/media/clips/Trance\ Energy\ 2002\ DvDSebRip.avi ! avidemux
name=demux .video_00 ! { queue ! ffdec_mpeg4 ! ffcolorspace ! mpeg2enc
format=9 ! queue ! mux.video_%d } { demux.audio_00 ! queue ! mad !
ffenc_mp2 ! queue ! mux.audio_%d } }

Which gives:

Pad video_0 linked with caps video/mpeg, systemstream=(boolean)FALSE,
mpegversion=(int)2, width=(int)16, height=(int)16,
framerate=(double)23.976024

as end caps.

Why were the changes needed (it worked fine, even in renegotiation)?
What do they do? And can you please try to make it work?

Thanks,

Ronald

-- 
Ronald Bultje <rbultje at ronald.bitfreak.net>
Linux Video/Multimedia developer