[gst-devel] Re: [gst-cvs] ds gstreamer: gstreamer/ gstreamer/gst/

[David Schleef]

On Mon, Jan 12, 2004 at 10:10:48AM +0100, Ronald Bultje wrote:
> Hi,
> 
> On Sun, 2004-01-11 at 23:37, David Schleef wrote:
> [create_sub]
> > -  GST_DATA_FLAG_SET (parent, GST_DATA_READONLY);
> 
> Just to be sure: did you move this check to the copy_on_write function?
> This check *is* important (and the current way was wrong, but removing
> it is wrong too... ;) ).

gst_buffer_copy_on_write() has copied buffers with refcount > 1 for
a long time.  Setting the parent's READONLY flag was just dumb.
Especially since it never _unset_ it.



dave...