[gst-devel] gst-indent changes

Thomas Vander Stichele thomas at apestaart.org
Mon Jul 19 02:49:01 CEST 2004


Hi,

> Hi gang,
> 
> I'd like to add "--braces-on-struct-decl-line" to gst-indent. Is that ok?
> 
> My problem is that I like this indentation (taken from gstbin.c):
> 
> typedef struct
> {
>   GstElementState pending;
>   GstElementStateReturn result;
> }
> SetKidStateData;
> 
> into this:
> 
> typedef struct {
>   GstElementState pending;
>   GstElementStateReturn result;
> } SetKidStateData;
> 
> Is that somehow possible with indent? I couldn't find a way to make indent
> do this

why would we want to change this ? It matches function definition, and
there's no good reason to just change indentation whenever someone wants
to because it breaks all patches coming from before it.  Which is why
the indent change was done when it was done.

You'll always find people wanting a different style, so I propose that
like before any indent change is done at some point in the cycle where
it's ok to break patch consistency.

Thomas


Dave/Dina : future TV today ! - http://www.davedina.org/
<-*- thomas (dot) apestaart (dot) org -*->
I love the way you love
but I hate the way
I'm supposed to love you back
<-*- thomas (at) apestaart (dot) org -*->
URGent, best radio on the net - 24/7 ! - http://urgent.fm/






More information about the gstreamer-devel mailing list