[gst-devel] Re: [gst-cvs] rbultje gst-plugins: gst-plugins/ gst-plugins/sys/oss/

Zaheer Abbas Merali zaheerabbas at merali.org
Sun Oct 24 22:56:04 CEST 2004


On 24 Oct 2004, at 15:25, Ronald S. Bultje wrote:

> I'm gonna piss off the flumotion people here, but the revert of their
> patch is on purpose. It breaks too many other things.
>
> For those who don't know, short expl.: GST_BUFFER_OFFSET_END() 
> indicates
> the offset of the end of the buffer (so begin + size), but nothing
> specifies the format. The patch from some time ago converts this into
> samples for osssrc (see below), whereas it used to be in bytes before
> that. Both would be equally correct and incorrect. The breakage is that
> they used osssrc->curoffset for this, which is specified to be in 
> bytes.
> they moved it to be in samples without converting the rest of the code
> to it, breaking the clock provided by osssrc, breaking osssrc querying
> and breaking timestamps in osssrc. Those aren't noticeable in 
> gst-launch
> pipelines, but they are noticeable in larger applications that use this
> (e.g. gst-rec. ;-) ).

That explains my clocking issues in acast with osssrc....

Thanks

Zaheer





More information about the gstreamer-devel mailing list