[gst-devel] Mastroska muxer 0.9 port

[Thomas Vander Stichele]

Hi Michal,


> 	I have ported Matroska muxer to 0.9. The patch is available in bugzilla
> as bug #318847
> http://bugzilla.gnome.org/show_bug.cgi?id=318847

I glanced over it, looks good.  One request - we use only /* */ - style
comments, could you update yours ?

> 	I have tried to follow all the guidelines (added many missing docs,
> tested by valgrind, used the version from 0.8 branch, ...)

Excellent.  You say you tested with valgrind - I assume you ran it on
gst-launch with some mkv files ? Any chance I can get you to add some
unit tests to check for your muxer ?

Thanks
Thomas


Dave/Dina : future TV today ! - http://www.davedina.org/
<-*- thomas (dot) apestaart (dot) org -*->
I could do so much harm
I could do you no good
I'll leave a stain in your heart I would
<-*- thomas (at) apestaart (dot) org -*->
URGent, best radio on the net - 24/7 ! - http://urgent.fm/