[gst-devel] sdlaudiosink / sdlvideosink patch

[Andrew Andkjar]

Hi All,

While developing an application that uses SDL itself  *and*   
sdlaudiosink (from gst-plugins-bad) I noticed (when my application  
mysteriously crashed after destroying the pipeline) that sdlaudiosink  
calls SDL_Quit() when the plugin is shutting down...   The audio sink  
only initialializes the SDL audio sub-system, so it seems  
inappropriate for it to shut down *all* SDL sub-systems.  The same  
principle applies to sdlvideosink as well.


 From SDL documentation:

http://www.libsdl.org/cgi/docwiki.cgi/SDL_5fQuit
http://www.libsdl.org/cgi/docwiki.cgi/SDL_5fQuitSubSystem

"SDL_Quit shuts down all SDL subsystems and frees the resources  
allocated to them."

"SDL_QuitSubSystem allows you to shut down a subsystem that has been  
previously initialized by  SDL_Init   or  SDL_InitSubSystem  . The   
flags   tells SDL_QuitSubSystem which subsystems to shut down, it  
uses the same values that are passed to  SDL_Init  ."


A trivial patch is attached that modifies sdlaudiosink and  
sdlvideosink to call SDL_QuitSubSystem instead of SDL_Quit.

Hope this is useful,

    Andrew

-------------- next part --------------
A non-text attachment was scrubbed...
Name: sdl_audio_video_sink_patch.diff
Type: application/octet-stream
Size: 1232 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20060818/5f417264/attachment.obj>
-------------- next part --------------