[gst-devel] x264 plugin patch and a couple of questions
bilboed at gmail.com
Mon Apr 2 09:17:06 CEST 2007
Just my morning 2cents comment, but we were thinking lately about
dts/pts on buffers. Since we don't have a dedicated field for that,
but we also want to keep the timestamp as PTS, you *could* use the
offset field of a buffer to store DTS.
There's still no defined behaviour regarding how to store DTS, but
using the offset would be the lesser evil and still allow you to have
On 3/30/07, Michal Benes <michal.benes at itonis.tv> wrote:
> Hi Roman,
> > I have created a simple patch for new x264 encoder plugin. It adds the
> > code which forwards log messages from libx264 to gst log subsystem,
> > maybe you will find it usefull.
> than you. It is indeed useful. I will adapt the patch little bit to
> match style of other gstreamer plugins.
> > I also have a couple of questions about this plugin
> > Why do you need to add one frame period to pts when b-frames are used?
> > You use timestamp queue to store/retrive buffer durations. But the
> > order of encoded frames can be different from the order of the
> > incoming buffers. I think you should lookup a queue entry with
> > timestamp equal to the pts of output picture, not just use the queue
> > as a ring buffer. Although I am not sure what practical value those
> > buffer durations have.
> The queue is used for generating DTS. This is probably not the best
> methos to do so, but it was reasonably easy one. PTS are retrieved from
> the decoder correctly. We use some hack for storing DTS which are later
> used by our mpeg-ts muxer. Packet queue would not be needed, because
> normal GttBuffers can not hold DTS.
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys-and earn cash
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
Multimedia editing developer / Fluendo S.A.
More information about the gstreamer-devel