[gst-devel] BUG: no default clock-rate in rtph263[p](pay|depay)

Wim Taymans wim at fluendo.com
Tue Jan 23 15:44:59 CET 2007


On Tue, 2007-01-23 at 14:54 +0100, Antoine Pitrou wrote:
> Le mardi 23 janvier 2007 à 12:28 +0100, Wim Taymans a écrit :
> > The real problem is that no caps negotiation is happening. A plugin is
> > free to refuse any buffers when they have no type information. If you
> > are using UDP to feed the payloaders, set the "caps" property on udpsrc
> > with the info from the SDP (or similar).
> 
> That's what I'm doing :) But since those caps are ignored anyway (and
> 90000 forced as a clock rate value), it would be logical for the default
> values to be set at initialization rather than at caps setting.
> 
The base class (will) extract and use other fields such as ssrc, rtptime
and seqnum-base to perform various checks and handle sync. These fields
have to be in the caps in the future so some negotiation has to be done.

Wim 

> For example, the following code doesn't use the provided caps at all
> (gstrtph263pay.c, lines 263-272):
> 
> static gboolean
> gst_rtp_h263_pay_setcaps (GstBaseRTPPayload * payload, GstCaps * caps)
> {
>   payload->pt = GST_RTP_PAYLOAD_H263;
>   gst_basertppayload_set_options (payload, "video", TRUE, "H263",
> 90000);
>   gst_basertppayload_set_outcaps (payload, NULL);
> 
>   return TRUE;
> }
> 
> Regards
> 
> Antoine.
> 
> 
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys - and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> gstreamer-devel mailing list
> gstreamer-devel at lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/gstreamer-devel
-- 
Wim Taymans <wim at fluendo.com>





More information about the gstreamer-devel mailing list