[gst-devel] Patch review: eliminate duplicate GstMixerTrack names

[Bastien Nocera]

On Thu, 2008-06-19 at 11:28 +0100, Bastien Nocera wrote:
> On Thu, 2008-06-19 at 11:22 +0100, Sam Morris wrote:
> <snip>
> > That's possible, but since there is already code in GstMixerTrack to
> > handle duplicate translated names it seemed logical to apply this
> > solution to handle untranslated names and also translated/untranslated
> > names of GstMixerOptions.
> > 
> > I get the feeling the ALSA developers do not consider this a problem;
> > the alsa-utils such as alsamixer already correctly handle the situation
> > by displaying the tracks to the user with the names "Capture", "Capture
> > 1", "Capture 2".
> > 
> > Output from 'amixer controls':
> > 
> >         numid=16,iface=MIXER,name='Input Source'
> >         numid=17,iface=MIXER,name='Input Source',index=1
> >         numid=18,iface=MIXER,name='Input Source',index=2
> > 
> > But I can always ask. I'd just prefer to not have to wait until 2.6.28
> > for this laptop to be usable. :(
> 
> Or you could simplify the code to use the index provided instead, if
> it's already available directly from ALSA. Rather than checking for
> dupes by hand.

I've updated the bugzilla.

The idea is right, but the implementation breaks translations, default
visible tracks, and modifies the prototype for a function needlessly.

Simply adding an index property on the element should be enough, as long
as it's followed by the necessary changes in gnome-volume-control and
the mixer-applet/control-center.