[gst-devel] gst_element_class_set_details() gone?

Benjamin Otte otte at redhat.com
Sun Apr 25 12:53:15 CEST 2010


I'm sorry that the commit message didn't include the why. I guess I had
talked so much about why on IRC that I assumed it was common knowledge
when I actually comitted the patch. :/

There's one big reason why I wanted thois function deprecated: It breaks
-Wwrite-strings and as we all agreed that that warning is rather
important, we don't want to expose APIs that can't cope with it.

Other reasons were that we had two APIs for exactly the same thing and
that's a bad idea, that APIs that expose a simple struct just so that it
can be passed as an argument to a single function is a bad API or that
this API does not work well from a bindings point of view.


On Sat, 2010-04-24 at 13:36 +0300, Felipe Contreras wrote:
> Hi,
> About this commit:
> http://cgit.freedesktop.org/gstreamer/gstreamer/commit/?id=3b4aa3f76a0252560151186bbdfb6be4e28880af
> The commit message is very bad; it's missing key information: why?
> According to Stefan; gst_element_class_set_details is causing a extra
> reloc and pointer copying. While that's probably true, the overhead is
> almost nothing, and only happens once, when the class is being
> initialized, right? It's ABI breakage for no reason.
> If a new API is in the works, that's cool, but since there's no better
> API right now, IMO the commit is doing more damage than good.
> FWIW, I'll be removing GST_DISABLE_DEPRECATED instead.
> Cheers.

More information about the gstreamer-devel mailing list