[PATCH] Allow pulseaudio writes in larger chunks

Sebastian Dröge sebastian.droege at collabora.co.uk
Thu Aug 18 05:46:16 PDT 2011


On Thu, 2011-08-18 at 14:07 +0200, David Henningsson wrote:
> The previous patch (posted several months ago) for improving pulsesink 
> writes was rejected, due to causing underruns when playing wma files. 
> I've been able to reproduce that error here, and have come up with a new 
> version of the patch which does not underruns in that case.
> 
> In short, the behavioural difference is
>   - without the patch, waiting and write size were both never above segsize
>   - with the old patch, both waiting and write size could grow up to 
> bufsize.
>   - with the new patch, waiting is done up to segsize. However when 
> waiting is done, it writes as much as it can.
> 
> Also, the previous patch was blamed to "ignore the latency-time" of the 
> sink. This statement is false, at least for the new version of the 
> patch. The latency is controlled by setting tlength and minreq 
> parameters of pa_buffer_attr, which in turn controls the behaviour of 
> pa_stream_writable_size.

Hi,

thanks for still working on this but could you put the patch in
Bugzilla, including your explanation of the various parts of the patch?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20110818/5b220633/attachment.pgp>


More information about the gstreamer-devel mailing list