gst-plugins-bad: aacparse: allow parsed frames on sink pad

[Sebastian Dröge]

On Sat, 2011-02-26 at 17:00 -0500, David Schleef wrote:
> On Sat, Feb 26, 2011 at 06:55:48PM +0100, Sebastian Dröge wrote:
> > On Sat, 2011-02-26 at 17:05 +0200, Stefan Kost wrote:
> > > Am 26.02.2011 15:43, schrieb Tim-Philipp Müller:
> > > > On Fri, 2011-02-25 at 20:02 -0800, David Schleef wrote:
> > > > 
> > > >> Module: gst-plugins-bad
> > > >> Branch: master
> > > >> Commit: e49b89d5c5a1244fa0dcb8bb4996e38fb9bff9e5
> > > >> URL:    http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=e49b89d5c5a1244fa0dcb8bb4996e38fb9bff9e5
> > > >>
> > > >> Author: David Schleef <ds at schleef.org>
> > > >> Date:   Wed Feb 23 17:25:03 2011 -0800
> > > >>
> > > >> aacparse: allow parsed frames on sink pad
> > > > 
> > > > Unfortunately we can't do that (yet) for parsers with a rank > NONE,
> > > > because it might lead to decodebin/decodebin2 autoplugging the same
> > > > parser over and over again in some cases..
> > > 
> > > I did that mistake once localy and I was wondering if we should extend the logic
> > > in decodebin to not replug an element in the same group?
> > 
> > Yes, something like that should be done.
> 
> Can this be done easily/quickly?  Otherwise, I'm likely to duplicate
> the element with a zero rank, so it can be used for transcoding.

Shouldn't be that much work, all the information is inside decodebin2
already. You only need to look at all elements in the current
GstDecodeChain and if the element you're going to plug next has the same
type as one of the elements in there you don't use it.

I'll work on it now and will CC you in the bugreport with the patch :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/gstreamer-devel/attachments/20110226/63dee7e6/attachment.pgp>