<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server">  <style></style> </head> <body> <font face="Calibri, sans-serif" size="2"> <div style="text-align: justify; ">Hi, </div> <div style="text-align: justify; ">I am proposing a way to add the camera control to the camera source element to turn on/off some feature in my camera.</div> <div style="text-align: justify; ">These features need to be exposed to user application for control in my camera. Currently, there is no such controls setting in the v4l2src.</div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; ">My propose is to add these control settings to photography interface and let the camera source element to implement the interface.</div> <div style="text-align: justify; ">My current implementation is combining all these features to one guint type, and add “guint advanced_mode;” to the GstPhotoSettings.</div> <div style="text-align: justify; ">I also defined one enum type to represent the features bit in advanced_mode.</div> <div style="text-align: justify; ">191 typedef enum</div> <div style="text-align: justify; ">192 {</div> <div style="text-align: justify; ">193   GST_PHOTOGRAPHY_GDC = (1 << 0), /* Geometry distortion correction*/</div> <div style="text-align: justify; ">194   GST_PHOTOGRAPHY_REDEYE = (1 << 1), /* Redeye reduction */</div> <div style="text-align: justify; ">195   GST_PHOTOGRAPHY_CAC = (1 << 2),/* Chromatic Aberration Correction*/</div> <div style="text-align: justify; ">196   GST_PHOTOGRAPHY_SHARPEN = (1 << 3),/* Edge enhancement */</div> <div style="text-align: justify; ">197   GST_PHOTOGRAPHY_DEMOSAIC = (1 << 4), /* False Color Correction */</div> <div style="text-align: justify; ">198   GST_PHOTOGRAPHY_DPC = (1 << 5), /*Defect Pixel Correction*/</div> <div style="text-align: justify; ">199   GST_PHOTOGRAPHY_SHADING = (1 << 6), /*Shading Correction */</div> <div style="text-align: justify; ">200   GST_PHOTOGRAPHY_BLACK_LEVEL = (1 << 7),/* Black level compensation */</div> <div style="text-align: justify; ">201   GST_PHOTOGRAPHY_IMAGE_STABLE = (1 << 8),/* Digital Image Stabilization */</div> <div style="text-align: justify; ">202       GST_PHOTOGRAPHY_VIDEO_STABLE = (1 << 9)/* VIDEO Stabilization */</div> <div style="text-align: justify; ">203 } GstAdvancedMode;</div> <div style="text-align: justify; ">More features can be added to the GstAdvancedMode to represent other features of the camera.</div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; ">So the user can use the following sequence to turn on the red eye reduction feature in the camera.</div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; ">guint adv;</div> <div style="text-align: justify; ">get_advanced_mode(photo, &adv);</div> <div style="text-align: justify; ">adv = adv | GST_PHOTOGRAPHY_REDEYE;</div> <div style="text-align: justify; ">set_advanced_mode (photo, adv);</div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; ">Any better idea to add the control to the camera source? Your comments are welcome.</div> <div style="text-align: justify; ">If this propose is feasible, I will submit my patch later.</div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; ">Best Regards!</div> <div style="text-align: justify; "><font face="Jokerman, fantasy" color="#404040"><i>Hu Gang</i></font></div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> <div style="text-align: justify; "><font face="Times New Roman, serif"> </font></div> </font> </body> </html>