<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> <meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type"> <title></title> </head> <body bgcolor="#ffffff" text="#000000"> On 10/21/2011 10:25 PM, RenXX Stadler wrote: <blockquote cite="mid:20111021202521.B3039C0002@kemper.freedesktop.org" type="cite"> <pre wrap="">Module: gst-plugins-base Branch: master Commit: 133a0b17715b2b7f106bed7ea0164451e9c33e94 URL: <a class="moz-txt-link-freetext" href="http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=133a0b17715b2b7f106bed7ea0164451e9c33e94">http://cgit.freedesktop.org/gstreamer/gst-plugins-base/commit/?id=133a0b17715b2b7f106bed7ea0164451e9c33e94</a> Author: RenÃ© Stadler <a class="moz-txt-link-rfc2396E" href="mailto:rene.stadler@collabora.co.uk"><rene.stadler@collabora.co.uk></a> Date: Fri Oct 21 21:41:03 2011 +0200 oggdemux: remove avoidable call to gst_object_set_name --- ext/ogg/gstoggdemux.c | 8 +++----- 1 files changed, 3 insertions(+), 5 deletions(-) diff --git a/ext/ogg/gstoggdemux.c b/ext/ogg/gstoggdemux.c index 3a880d4..f739df0 100644 --- a/ext/ogg/gstoggdemux.c +++ b/ext/ogg/gstoggdemux.c @@ -1692,7 +1692,9 @@ gst_ogg_chain_new_stream (GstOggChain * chain, guint32 serialno) GST_DEBUG_OBJECT (chain->ogg, "creating new stream %08x in chain %p", serialno, chain); - ret = g_object_new (GST_TYPE_OGG_PAD, NULL); + name = g_strdup_printf ("serial_%08x", serialno); + ret = g_object_new (GST_TYPE_OGG_PAD, "name", name, NULL); + g_free (name); </pre> </blockquote> what about gchar name[sizeof("serial_")+8] while you are on it Stefan <blockquote cite="mid:20111021202521.B3039C0002@kemper.freedesktop.org" type="cite"> <pre wrap=""> /* we own this one */ gst_object_ref (ret); gst_object_sink (ret); @@ -1707,10 +1709,6 @@ gst_ogg_chain_new_stream (GstOggChain * chain, guint32 serialno) if (ogg_stream_init (&ret->map.stream, serialno) != 0) goto init_failed; - name = g_strdup_printf ("serial_%08x", serialno); - gst_object_set_name (GST_OBJECT (ret), name); - g_free (name); - /* FIXME: either do something with it or remove it */ list = gst_tag_list_new (); gst_tag_list_add (list, GST_TAG_MERGE_REPLACE, GST_TAG_SERIAL, serialno, </pre> <pre wrap=""> <fieldset class="mimeAttachmentHeader"></fieldset> _______________________________________________ gstreamer-commits mailing list <a class="moz-txt-link-abbreviated" href="mailto:gstreamer-commits@lists.freedesktop.org">gstreamer-commits@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits">http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits</a> </pre> </blockquote> </body> </html>