<div dir="ltr">Hi Ian,<div> </div><div>Oh yes, good spot. Originally I had an 'if' statement around each call but knowing that this was only a proposal I wanted to keep it shorter. You're right, should be |=.</div> <div style>As the comment on the ticket states I'll try g_unix_signal_add() approach in a spare moment and will look in glib if there's an opportunity to use signalfd() there.</div> <div style> </div><div style>Cheers,</div><div style>Kris </div> </div><div class="gmail_extra"> <div class="gmail_quote">2013/2/12 Ian Davidson <<a href="mailto:id012c3076@blueyonder.co.uk" target="_blank">id012c3076@blueyonder.co.uk</a>> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> Hi Kris, I have been looking at your code and I might be about to make a fool of myself - but here goes. You have coded some lines - I'll just quote 2 int res = 0; res &= sigemptyset (&mask); It is the &= which bothers me. Since ret starts off as zero, ANDing anything to that means that ret will continue to be zero. Shouldn't you have used |= ? Ian<div class="HOEnZb"><div class="h5"> On 09/02/2013 16:45, Krzysztof Konopko wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 04/02/13 10:44, Krzysztof Konopko wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On 02/02/13 23:39, Tim-Philipp Müller wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Sat, 2013-02-02 at 16:58 +0000, Krzysztof Konopko wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I think that gst-launch doesn't take the best approach to signal handling. Use signalfd instead [1]. An example might be useful [2]. You get a file descriptor which you can watch it with g_io_add_watch() [3]. </blockquote> Yes, that would indeed be better. However, we'll probably have to keep the old code for compatibility reasons anyway. Feel free to make a patch :) Cheers -Tim </blockquote> Oh yes, I'd like to grapple with it, although signalfd() is not directly available in all libc implementations, e. g. some uClibc versions do not provide it so need to make a syscall directly (need to roll out autotools/preprocessor machinery to cater for this). Also for SIGSEGV (and probably SIGBUS) still need to use the classic approach (these are some of which signals where originally designed for). So need to give it a bit of thinking in case of gst-launch. In user apps it seems to be of less hassle. Cheers, Kris </blockquote> I gave it a go: <a href="https://bugzilla.gnome.org/show_bug.cgi?id=693481" target="_blank">https://bugzilla.gnome.org/show_bug.cgi?id=693481</a> Cheers, Kris <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> _______________________________________________ gstreamer-devel mailing list <a href="mailto:gstreamer-devel@lists.freedesktop.org" target="_blank">gstreamer-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a> </blockquote> _______________________________________________ gstreamer-devel mailing list <a href="mailto:gstreamer-devel@lists.freedesktop.org" target="_blank">gstreamer-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a> </blockquote> _______________________________________________ gstreamer-devel mailing list <a href="mailto:gstreamer-devel@lists.freedesktop.org" target="_blank">gstreamer-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a> </blockquote> _______________________________________________ gstreamer-devel mailing list <a href="mailto:gstreamer-devel@lists.freedesktop.org" target="_blank">gstreamer-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a> </div></div></blockquote></div> </div>