<HTML><HEAD><TITLE>Mail</TITLE> <META name=GENERATOR content="KsDHTMLEDLib.ocx, FreeWare HTML Editor 1.164.2, ?Kurt Senfer"> <META content="text/html; charset=GB2312" http-equiv=Content-Type></HEAD> <BODY style="FONT-SIZE: 9pt; FONT-FAMILY: 新宋体" leftMargin=5 topMargin=5 #ffffff> <DIV>Hello everyone,</DIV> <DIV> I'm learning gstreamer gl plugin , and I found there is a bug in </DIV> <DIV>gstglfiltershader.c , when loading shader file ,it should pass "r"(for fopen)</DIV> <DIV>instead of O_RDONLY (for open) ,this leads a crash when using glshader </DIV> <DIV>element. and here's a quick fix. (based on gst-plugins-gl-0.10.3)</DIV> <DIV>plus, is there some example shader file </DIV> <DIV> or some detail document? glshader may be greate for shader based video process test,</DIV> <DIV>but documents said little about "vars" file format or "preset" file format</DIV> <DIV> </DIV> <DIV>--- a/gst/gl/gstglfiltershader.c 2012-05-08 12:43:19.000000000 +0800<BR>+++ b/gst/gl/gstglfiltershader.c 2013-06-20 15:49:52.639081794 +0800<BR>@@ -263,7 +263,7 @@<BR> <BR> // read the filter from file<BR> GST_INFO ("loading file: %s", filename);<BR>- f = fopen (filename, O_RDONLY);<BR>+ f = fopen (filename, "r");<BR> if (f == NULL) {<BR> GST_ERROR ("could not open file: %s", filename);<BR> return -1;</DIV> <DIV> </DIV> <DIV> </DIV> <DIV> </DIV> <DIV></DIV> <DIV>comicfans44</DIV> <DIV> </DIV></BODY></HTML>