<div dir="ltr">Just running autogen.sh and make a Ubuntu Desktop 13.10 amd64, so I haven't really made a conscience choice regarding debugging and -Werror. Just compiling out of the box wjich fails for plugins-bad. <div class="gmail_extra"> <div class="gmail_quote">On Thu, May 8, 2014 at 10:52 PM, Sebastian Dröge <<a href="mailto:sebastian@centricular.com" target="_blank">sebastian@centricular.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Do, 2014-05-08 at 10:32 -0400, Nicolas Dufresne wrote: > Le mercredi 07 mai 2014 à 22:44 +0200, Peter Maersk-Moller a écrit : > > Hi. > > > > > > > > Error preventsGit Master gst-plugins-bad from compiling. The errors > > are: > > > > make[5]: Entering directory > > `/home/stream/Projects/GStreamer/Git/gst-plugins-bad/gst-libs/gst/gl' > > CC libgstgl_1.0_la-gstgldisplay.lo > > gstgldisplay.c: In function 'gst_gl_display_new': > > gstgldisplay.c:115:30: error: variable 'platform_choice' set but not > > used [-Werror=unused-but-set-variable] > > const gchar *user_choice, *platform_choice; > > ^ > > cc1: all warnings being treated as errors > > make[5]: *** [libgstgl_1.0_la-gstgldisplay.lo] Error 1 > > > > > > If 'GST_GL_HAVE_PLATFORM_EGL' is not defined, then platform_choice is > > defined and set, but not used which with the configured compiling > > settings throws an error. If the setting of platform_choice is moved > > in under the > > '#if GST_GL_HAVE_PLATFORM_EGL' then the platform_choice is defined, > > but not used throwing an error. So that must be guarded as well by the > > 'GST_GL_HAVE_PLATFORM_EGL. > > > It's used always if debug traces is enabled. So I suppose you disabled > debug traces in your build and EGL is the only supported platform. > > if (!display) { > /* subclass returned a NULL window */ > GST_WARNING ("Could not create display. user specified %s, creating > dummy", > user_choice ? user_choice : "(null)"); > > This is a bit tricky/twisted to fix, please file a bug, <a href="http://bugs.gnome.org" target="_blank">bugs.gnome.org</a> > produce GStreamer component gst-plugins-bad. </div></div>The problem is that platform_choice is not always used, not user_choice. Which is fixed by this commit now: <a href="http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=5c960069e44d043bd60903046c905873fe63d93f" target="_blank">http://cgit.freedesktop.org/gstreamer/gst-plugins-bad/commit/?id=5c960069e44d043bd60903046c905873fe63d93f</a> It will still complain if you build without debugging enabled, but we don't support -Werror compilation without debugging as it's really just adding a lot of noise and #ifdefs to the code. -- Sebastian Dröge, Centricular Ltd - <a href="http://www.centricular.com" target="_blank">http://www.centricular.com</a> Expertise, Straight from the Source _______________________________________________ gstreamer-devel mailing list <a href="mailto:gstreamer-devel@lists.freedesktop.org">gstreamer-devel@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-devel</a> </blockquote></div> </div></div>