<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
text-align:justify;
text-justify:inter-ideograph;
font-size:10.5pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
/* Page Definitions */
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=ZH-CN link=blue vlink=purple style='text-justify-trim:punctuation'><div class=WordSection1><p class=MsoNormal><span lang=EN-US>Hi all:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>I sent an email about the hot-plug issue about USB earphone before. These days, I trace the log, and found that when I plugged out the device, it came to an endless loop in gst_directsound_sink_write; calculate_freesize was called everytime. So, if gst_element_set_state was called in another thread, gst_directsound_sink_reset triggered, Which may blocked, due to GST_DSOUND_LOCK (dsoundsink).<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>I added a variable “reset” in GstDirectSoundSink to indicate the reset of a sink. It will be set true before GST_DSOUND_LOCK (dsoundsink) in gst_directsound_sink_reset:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>static void<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>gst_directsound_sink_reset (GstAudioSink * asink)<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>{<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> GstDirectSoundSink *dsoundsink;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> LPVOID pLockedBuffer = NULL;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> DWORD dwSizeBuffer = 0;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US> dsoundsink = GST_DIRECTSOUND_SINK (asink);<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> dsoundsink->reset = TRUE;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US> GST_DSOUND_LOCK (dsoundsink);<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US> ……<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>}<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>In the calculate_freesize loop, modified as below:<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>if (SUCCEEDED (hRes) && (dwStatus & DSBSTATUS_PLAYING) && !dsoundsink->reset)<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> goto calculate_freesize;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>else {<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> dsoundsink->first_buffer_after_reset = FALSE;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> dsoundsink->reset = FALSE;<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> GST_DSOUND_UNLOCK (dsoundsink);<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US> return 0; <o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>}<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>After modified, the stuck issue was gone. I want to ask you guys, if this is a good idea or a bad one. If bad, do you have any other solutions?<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>PS: I haven’t looked deep into the logic of calculate_freesize loop. So maybe there is a better way to break the loop which I have not found.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>Thanks!<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US>--<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US>Yongjian<o:p></o:p></span></p></div></body></html>