<div dir="ltr"> <div class="gmail_extra"> <div class="gmail_quote">2014-06-23 9:37 GMT+02:00 Edward Hervey <<a href="mailto:bilboed@kemper.freedesktop.org" target="_blank">bilboed@kemper.freedesktop.org</a>>: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Module: cerbero Branch: master Commit: ce92730c24af514dd6b4845db17eee91bd736064 URL: <a href="http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=ce92730c24af514dd6b4845db17eee91bd736064" target="_blank">http://cgit.freedesktop.org/gstreamer/cerbero/commit/?id=ce92730c24af514dd6b4845db17eee91bd736064</a> Author: Edward Hervey <<a href="mailto:bilboed@bilboed.com">bilboed@bilboed.com</a>> Date: Mon Jun 16 15:41:22 2014 +0200 packages: Update for gst-plugins-bad libraries <a href="https://bugzilla.gnome.org/show_bug.cgi?id=728154" target="_blank">https://bugzilla.gnome.org/show_bug.cgi?id=728154</a> --- packages/gstreamer-1.0-capture.package | 2 +- packages/gstreamer-1.0-codecs-restricted.package | 2 +- packages/gstreamer-1.0-codecs.package | 2 +- packages/gstreamer-1.0-system.package | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/gstreamer-1.0-capture.package b/packages/gstreamer-1.0-capture.package index 1aba654..0d2aaf3 100644 --- a/packages/gstreamer-1.0-capture.package +++ b/packages/gstreamer-1.0-capture.package @@ -19,7 +19,7 @@ class Package(package.Package): files = ['gst-plugins-base-1.0:plugins_capture', 'gst-plugins-good-1.0:plugins_capture', 'gst-plugins-ugly-1.0:plugins_capture', - 'gst-plugins-bad-1.0:plugins_capture'] + 'gst-plugins-bad-1.0:plugins_capture:libs'] files_devel = ['gst-plugins-base-1.0-static:plugins_capture_devel' 'gst-plugins-good-1.0-static:plugins_capture_devel', 'gst-plugins-ugly-1.0-static:plugins_capture_devel', diff --git a/packages/gstreamer-1.0-codecs-restricted.package b/packages/gstreamer-1.0-codecs-restricted.package index 2b103e3..361fae1 100644 --- a/packages/gstreamer-1.0-codecs-restricted.package +++ b/packages/gstreamer-1.0-codecs-restricted.package @@ -19,7 +19,7 @@ class Package(package.Package): files = ['a52dec:libs', 'opencore-amr:libs', 'libmad:libs', 'libmpeg2:libs', 'faad2:libs', 'libdca:libs', 'vo-aacenc:libs', 'x264:libs', 'gst-plugins-ugly-1.0:plugins_codecs_restricted', - 'gst-plugins-bad-1.0:plugins_codecs_restricted'] + 'gst-plugins-bad-1.0:plugins_codecs_restricted:libs'] files_devel = ['gst-plugins-ugly-1.0-static:plugins_codecs_restricted_devel', 'gst-plugins-bad-1.0-static:plugins_codecs_restricted_devel'] diff --git a/packages/gstreamer-1.0-codecs.package b/packages/gstreamer-1.0-codecs.package index 085a5b5..801e1b3 100644 --- a/packages/gstreamer-1.0-codecs.package +++ b/packages/gstreamer-1.0-codecs.package @@ -21,7 +21,7 @@ class Package(package.Package): 'libtheora:libs', 'wavpack:libs', 'libvpx:libs', 'taglib:libs', 'opus:libs', 'libvorbis:libs', 'gst-plugins-base-1.0:plugins_codecs', 'gst-plugins-good-1.0:plugins_codecs', - 'gst-plugins-bad-1.0:plugins_codecs', 'gst-plugins-ugly-1.0:plugins_codecs', + 'gst-plugins-bad-1.0:plugins_codecs:libs', 'gst-plugins-ugly-1.0:plugins_codecs', ] files_devel = ['gst-plugins-base-1.0-static:plugins_codecs_devel', 'gst-plugins-good-1.0-static:plugins_codecs_devel', diff --git a/packages/gstreamer-1.0-system.package b/packages/gstreamer-1.0-system.package index 7a78548..92f0df7 100644 --- a/packages/gstreamer-1.0-system.package +++ b/packages/gstreamer-1.0-system.package @@ -17,7 +17,7 @@ class Package(package.Package): deps = ['gstreamer-1.0-core'] files = ['gst-plugins-base-1.0:plugins_sys', 'gst-plugins-good-1.0:plugins_sys', - 'gst-plugins-ugly-1.0:plugins_sys', 'gst-plugins-bad-1.0:plugins_sys'] + 'gst-plugins-ugly-1.0:plugins_sys', 'gst-plugins-bad-1.0:plugins_sys:libs'] files_devel = ['gst-plugins-base-1.0-static:plugins_sys_devel', 'gst-plugins-good-1.0-static:plugins_sys_devel', 'gst-plugins-ugly-1.0-static:plugins_sys_devel', </blockquote><div> </div><div>Hi, I don't think this set of patches is correct from the point of view of the packages. This would include the -bad libraries in several packages, ending up with duplicated files, which is a problem for .deb and .rpm packages as it will complain about the same file being installed by several packages. </div><div>I think the correct way of handling this is adding the gst-plugins-bad:libs to the gstreamer-core package, which includes the libraries from gstreamer and gstreamer-base. Cheers, Andoni </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> _______________________________________________ gstreamer-commits mailing list <a href="mailto:gstreamer-commits@lists.freedesktop.org">gstreamer-commits@lists.freedesktop.org</a> <a href="http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits" target="_blank">http://lists.freedesktop.org/mailman/listinfo/gstreamer-commits</a> </blockquote></div> -- Andoni Morales Alastruey LongoMatch:The Digital Coach <a href="http://www.longomatch.ylatuya.es">http://www.longomatch.ylatuya.es</a> </div></div>