[Gstreamer-openmax] [PATCH 2/2] add gst-openmax registry (config file)
felipe.contreras at gmail.com
Fri Feb 26 14:20:36 PST 2010
On Sat, Feb 27, 2010 at 12:03 AM, Clark, Rob <rob at ti.com> wrote:
> so something like:
Yeah, but type => parent, derived-type = type.
> it does make the config file more complex (one more thing to misconfigure), and then we need a bit more error handling, in case user specifies a type name that already exists.. so I'm not super-excited about that.
I don't think we need to spend so much code to check for duplicated
types, the type register would fail. Besides, what happens if you
derive from a class that's not GstOmx; I don't think the proneness to
errors is increasing that much by adding one field more.
> Also, then we need an additional hash-table to map back to element name (or something like g_type_set_qdata()).. both is possible, but it makes the code slightly less simple.
Why do we need to map back to element names? As you said; the user can
select any name anyways. (We are using g_type_set_qdata() already)
> using the element name as the type name seems a simple solution to both.
Yeah, it's simple but doesn't feel right to me. I am picturing myself
reading some debug log, scratching my head and then saying: ohh,
omx_dummy was the _class_ name!
More information about the Gstreamer-openmax