[Gstreamer-openmax] [PATCH 1/2] use G_PARAM_STATIC_STRINGS

Rob Clark rob at ti.com
Sat Mar 6 13:03:57 PST 2010


as suggested by Stefan Kost
---
 omx/gstomx_aacenc.c        |    7 ++++---
 omx/gstomx_amrnbenc.c      |    3 ++-
 omx/gstomx_amrwbenc.c      |    3 ++-
 omx/gstomx_base_filter.c   |    6 +++---
 omx/gstomx_base_sink.c     |    4 ++--
 omx/gstomx_base_src.c      |    4 ++--
 omx/gstomx_base_videoenc.c |    3 ++-
 omx/gstomx_filereadersrc.c |    2 +-
 omx/gstomx_g729enc.c       |    2 +-
 omx/gstomx_jpegenc.c       |    3 ++-
 omx/gstomx_videosink.c     |    6 +++---
 11 files changed, 24 insertions(+), 19 deletions(-)

diff --git a/omx/gstomx_aacenc.c b/omx/gstomx_aacenc.c
index eabc855..ae870e3 100644
--- a/omx/gstomx_aacenc.c
+++ b/omx/gstomx_aacenc.c
@@ -261,20 +261,21 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_BITRATE,
                                          g_param_spec_uint ("bitrate", "Bit-rate",
                                                             "Encoding bit-rate",
-                                                            0, G_MAXUINT, DEFAULT_BITRATE, G_PARAM_READWRITE));
+                                                            0, G_MAXUINT, DEFAULT_BITRATE,
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
         g_object_class_install_property (gobject_class, ARG_PROFILE,
                                          g_param_spec_enum ("profile", "Enocding profile",
                                                             "OMX_AUDIO_AACPROFILETYPE of output",
                                                             GST_TYPE_OMX_AACENC_PROFILE,
                                                             DEFAULT_PROFILE,
-                                                            G_PARAM_READWRITE));
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
         g_object_class_install_property (gobject_class, ARG_OUTPUT_FORMAT,
                                          g_param_spec_enum ("output-format", "Output format",
                                                             "OMX_AUDIO_AACSTREAMFORMATTYPE of output",
                                                             GST_TYPE_OMX_AACENC_OUTPUT_FORMAT,
                                                             DEFAULT_OUTPUT_FORMAT,
-                                                            G_PARAM_READWRITE));
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_amrnbenc.c b/omx/gstomx_amrnbenc.c
index d8b921b..9cd3e7a 100644
--- a/omx/gstomx_amrnbenc.c
+++ b/omx/gstomx_amrnbenc.c
@@ -165,7 +165,8 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_BITRATE,
                                          g_param_spec_uint ("bitrate", "Bit-rate",
                                                             "Encoding bit-rate",
-                                                            0, G_MAXUINT, DEFAULT_BITRATE, G_PARAM_READWRITE));
+                                                            0, G_MAXUINT, DEFAULT_BITRATE,
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_amrwbenc.c b/omx/gstomx_amrwbenc.c
index 176ccb3..9a11f48 100644
--- a/omx/gstomx_amrwbenc.c
+++ b/omx/gstomx_amrwbenc.c
@@ -165,7 +165,8 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_BITRATE,
                                          g_param_spec_uint ("bitrate", "Bit-rate",
                                                             "Encoding bit-rate",
-                                                            0, G_MAXUINT, DEFAULT_BITRATE, G_PARAM_READWRITE));
+                                                            0, G_MAXUINT, DEFAULT_BITRATE,
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_base_filter.c b/omx/gstomx_base_filter.c
index da41b4d..6ddfc85 100644
--- a/omx/gstomx_base_filter.c
+++ b/omx/gstomx_base_filter.c
@@ -260,17 +260,17 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_COMPONENT_NAME,
                                          g_param_spec_string ("component-name", "Component name",
                                                               "Name of the OpenMAX IL component to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
         g_object_class_install_property (gobject_class, ARG_LIBRARY_NAME,
                                          g_param_spec_string ("library-name", "Library name",
                                                               "Name of the OpenMAX IL implementation library to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
         g_object_class_install_property (gobject_class, ARG_USE_TIMESTAMPS,
                                          g_param_spec_boolean ("use-timestamps", "Use timestamps",
                                                                "Whether or not to use timestamps",
-                                                               TRUE, G_PARAM_READWRITE));
+                                                               TRUE, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_base_sink.c b/omx/gstomx_base_sink.c
index 68c7ea7..560a0f1 100644
--- a/omx/gstomx_base_sink.c
+++ b/omx/gstomx_base_sink.c
@@ -336,12 +336,12 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_COMPONENT_NAME,
                                          g_param_spec_string ("component-name", "Component name",
                                                               "Name of the OpenMAX IL component to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
         g_object_class_install_property (gobject_class, ARG_LIBRARY_NAME,
                                          g_param_spec_string ("library-name", "Library name",
                                                               "Name of the OpenMAX IL implementation library to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_base_src.c b/omx/gstomx_base_src.c
index bae9f55..d09a8d2 100644
--- a/omx/gstomx_base_src.c
+++ b/omx/gstomx_base_src.c
@@ -397,12 +397,12 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_COMPONENT_NAME,
                                          g_param_spec_string ("component-name", "Component name",
                                                               "Name of the OpenMAX IL component to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
 
         g_object_class_install_property (gobject_class, ARG_LIBRARY_NAME,
                                          g_param_spec_string ("library-name", "Library name",
                                                               "Name of the OpenMAX IL implementation library to use",
-                                                              NULL, G_PARAM_READABLE));
+                                                              NULL, G_PARAM_READABLE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_base_videoenc.c b/omx/gstomx_base_videoenc.c
index f788817..6f21a48 100644
--- a/omx/gstomx_base_videoenc.c
+++ b/omx/gstomx_base_videoenc.c
@@ -156,7 +156,8 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_BITRATE,
                                          g_param_spec_uint ("bitrate", "Bit-rate",
                                                             "Encoding bit-rate",
-                                                            0, G_MAXUINT, DEFAULT_BITRATE, G_PARAM_READWRITE));
+                                                            0, G_MAXUINT, DEFAULT_BITRATE,
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_filereadersrc.c b/omx/gstomx_filereadersrc.c
index cea5ca9..a391b69 100644
--- a/omx/gstomx_filereadersrc.c
+++ b/omx/gstomx_filereadersrc.c
@@ -181,7 +181,7 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_FILE_NAME,
                                          g_param_spec_string ("file-name", "File name",
                                                               "The input filename to use",
-                                                              NULL, G_PARAM_READWRITE));
+                                                              NULL, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_g729enc.c b/omx/gstomx_g729enc.c
index 1a2c853..6a47c0f 100644
--- a/omx/gstomx_g729enc.c
+++ b/omx/gstomx_g729enc.c
@@ -170,7 +170,7 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_DTX,
                                          g_param_spec_boolean ("dtx", "DTX",
                                                                "Enable DTX",
-                                                               DEFAULT_DTX, G_PARAM_READWRITE));
+                                                               DEFAULT_DTX, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_jpegenc.c b/omx/gstomx_jpegenc.c
index e78b5b1..2c7c1a1 100644
--- a/omx/gstomx_jpegenc.c
+++ b/omx/gstomx_jpegenc.c
@@ -187,7 +187,8 @@ type_class_init (gpointer g_class,
         g_object_class_install_property (gobject_class, ARG_QUALITY,
                                          g_param_spec_uint ("quality", "Quality of image",
                                                             "Set the quality from 0 to 100",
-                                                            0, 100, DEFAULT_QUALITY, G_PARAM_READWRITE));
+                                                            0, 100, DEFAULT_QUALITY,
+                                                            G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
     }
 }
 
diff --git a/omx/gstomx_videosink.c b/omx/gstomx_videosink.c
index 923b5ed..3a8cbaa 100644
--- a/omx/gstomx_videosink.c
+++ b/omx/gstomx_videosink.c
@@ -308,17 +308,17 @@ type_class_init (gpointer g_class,
     g_object_class_install_property (gobject_class, ARG_X_SCALE,
                                      g_param_spec_uint ("x-scale", "X Scale",
                                                         "How much to scale the image in the X axis (100 means nothing)",
-                                                        0, G_MAXUINT, 100, G_PARAM_READWRITE));
+                                                        0, G_MAXUINT, 100, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
     g_object_class_install_property (gobject_class, ARG_Y_SCALE,
                                      g_param_spec_uint ("y-scale", "Y Scale",
                                                         "How much to scale the image in the Y axis (100 means nothing)",
-                                                        0, G_MAXUINT, 100, G_PARAM_READWRITE));
+                                                        0, G_MAXUINT, 100, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 
     g_object_class_install_property (gobject_class, ARG_ROTATION,
                                      g_param_spec_uint ("rotation", "Rotation",
                                                         "Rotation angle",
-                                                        0, G_MAXUINT, 360, G_PARAM_READWRITE));
+                                                        0, G_MAXUINT, 360, G_PARAM_READWRITE | G_PARAM_STATIC_STRINGS));
 }
 
 static void
-- 
1.6.3.2





More information about the Gstreamer-openmax mailing list