<br><br><div class="gmail_quote">On Fri, Mar 27, 2009 at 5:43 AM, Felipe Contreras <span dir="ltr"><<a href="mailto:felipe.contreras@gmail.com">felipe.contreras@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hi,<br>
<br>
I've taken your patch and I've put it in a new branch in github. I<br>
took a quick look and it seems it will require quite a bit of effort<br>
before this can be merged, bit doesn't look bad :)<br>
<br>
First I want to start minimizing the changes and I already started<br>
with the aacdec, can you take a look and see if you can do the same<br>
for the other components?</blockquote><div><br>OK, but I can do it after completing video flinger sink and java glue code.<br> <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
A few comments:<br>
<br>
Remove BUILD_WITH_ANDROID, for now this branch should be only for<br>
Android. Once it's clean we can start merging the stuff that can be<br>
shared by all the omx implementations and then rebase on top of the<br>
latest master.</blockquote><div>OK, actually, most of them is not android specific, they shall be moved outside BUILD_WITH_ANDROID. But, we need analyze them case by case, because I'm not sure if PV OpenMax follow spec strictly. <br>
</div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
Can we remove the extra debugging stuff like "Enter" and "Leave"? Once<br>
the android branch is merged we can think on adding them back.<br>
<br>
Also, is it possible for you to use the branch I just setup? Or a fork<br>
of it? That way we can verify that there are no regressions in the<br>
process.<br>
<br>
<a href="http://github.com/felipec/gst-openmax/commits/android" target="_blank">http://github.com/felipec/gst-openmax/commits/android</a><br>
</blockquote><div><br>Of cause, I can use your branch. <br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
Cheers.<br>
<div><div></div><div class="h5"><br>
On Thu, Mar 26, 2009 at 5:26 PM, Prajnashi S <<a href="mailto:prajnashi@gmail.com">prajnashi@gmail.com</a>> wrote:<br>
><br>
><br>
> ---------- Forwarded message ----------<br>
> From: Prajnashi <<a href="mailto:prajnashi@gmail.com">prajnashi@gmail.com</a>><br>
> Date: Thu, Mar 26, 2009 at 11:22 PM<br>
> Subject: View this page "Port all packages step by step"<br>
> To: prajnashi <<a href="mailto:prajnashi@googlegroups.com">prajnashi@googlegroups.com</a>><br>
><br>
><br>
><br>
> Update pages to make gst-openmax support amrnb, amrwb, h263, h264,<br>
> mpeg4. You can use following command to test.<br>
><br>
> Play a amrwb 3gp file<br>
><br>
> # ./gst-launch-0.10 filesrc location=wb.3gp ! qtdemux ! queue !<br>
> omx_amrwbdec ! audioflingersink<br>
><br>
><br>
> Play a mp4 video file:<br>
><br>
> # ./gst-launch-0.10 filesrc location=1.mp4 ! qtdemux ! queue !<br>
> omx_mpeg4dec ! ffmpegcolorspace ! fbdevsink<br>
><br>
><br>
><br>
> Play a h264 video file:<br>
><br>
> # ./gst-launch-0.10 filesrc location=264.mp4 ! qtdemux ! queue !<br>
> omx_h264dec ! ffmpegcolorspace ! fbdevsink<br>
><br>
><br>
> Play a h263 video file:<br>
><br>
> # ./gst-launch-0.10 filesrc location=263.mp4 ! qtdemux ! queue !<br>
> omx_h263dec ! ffmpegcolorspace ! fbdevsink<br>
><br>
><br>
> Play a mp4 + aac file:<br>
><br>
> # ./gst-launch-0.10 filesrc location=av.mp4 ! qtdemux name=demux<br>
> demux. ! omx_aacdec ! audioflingersink demux. ! omx_mpeg4dec !<br>
> ffmpegcolorspace ! fbdevsink<br>
><br>
><br>
> Play a h263 + amrnb file:<br>
><br>
> # ./gst-launch-0.10 filesrc location=av.3gp ! qtdemux name=demux<br>
> demux. ! omx_amrnbdec ! audioflingersink demux. ! omx_h263dec !<br>
> ffmpegcolorspace ! fbdevsink<br>
><br>
><br>
> Click on<br>
> <a href="http://groups.google.com/group/prajnashi/web/port-all-packages-step-by-step" target="_blank">http://groups.google.com/group/prajnashi/web/port-all-packages-step-by-step</a><br>
> - or copy & paste it into your browser's address bar if that doesn't<br>
> work.<br>
> --~--~---------~--~----~------------~-------~--~----~<br>
> You received this message because you are subscribed to the Google Groups<br>
> "prajnashi" group.<br>
> To post to this group, send email to <a href="mailto:prajnashi@googlegroups.com">prajnashi@googlegroups.com</a><br>
> To unsubscribe from this group, send email to<br>
> <a href="mailto:prajnashi%2Bunsubscribe@googlegroups.com">prajnashi+unsubscribe@googlegroups.com</a><br>
> For more options, visit this group at<br>
> <a href="http://groups.google.com/group/prajnashi?hl=en" target="_blank">http://groups.google.com/group/prajnashi?hl=en</a><br>
> -~----------~----~----~----~------~----~------~--~---<br>
><br>
><br>
><br>
><br>
> --<br>
> -- Prajnashi S<br>
><br>
</div></div>> ------------------------------------------------------------------------------<br>
><br>
> _______________________________________________<br>
> Gstreamer-openmax mailing list<br>
> <a href="mailto:Gstreamer-openmax@lists.sourceforge.net">Gstreamer-openmax@lists.sourceforge.net</a><br>
> <a href="https://lists.sourceforge.net/lists/listinfo/gstreamer-openmax" target="_blank">https://lists.sourceforge.net/lists/listinfo/gstreamer-openmax</a><br>
><br>
><br>
<br>
<br>
<br>
--<br>
<font color="#888888">Felipe Contreras<br>
</font></blockquote></div><br><br clear="all"><br>-- <br>-- Prajnashi S<br>