hal ChangeLog,1.158,1.159

Joe Shaw joe at pdx.freedesktop.org
Wed Jun 9 11:12:01 PDT 2004


Update of /cvs/hal/hal
In directory pdx:/tmp/cvs-serv14626

Modified Files:
	ChangeLog 
Log Message:
2004-06-09  Joe Shaw  <joeshaw at novell.com>

	Fix some refcounting issues

	* hald/linux/block_class_device.c: Unref the device after we add
	it to the TDL.
	(disc_add_to_gdl): Removed; it's functionally equivalent to
	device_move_from_tdl_to_gdl() in common.c.
	(disc_remove_from_gdl): Disconnect the signal handlers before
	removing from the TDL (and thus finalizing).
	(detect_media): Unref the child after adding it to the TDL.
	Replace signal handler for "callouts_finished".

	* hald/linux/bus_device.c (bus_device_visit): Unref device after
	adding it to the TDL.
	(bus_device_got_parent): Don't unref after removing from the TDL.

	* hald/linux/class_device.c (class_device_visit): Unref device
	after adding it to TDL.
	(class_device_got_parent_device, class_device_got_sysdevice,
	class_device_got_device_file, class_device_final): Don't unref
	after removing from the TDL.

	* hald/linux/osspec.c (osspec_probe): Unref the fakeroot device
	after adding it to GDL.

Index: ChangeLog
===================================================================
RCS file: /cvs/hal/hal/ChangeLog,v
retrieving revision 1.158
retrieving revision 1.159
diff -u -d -r1.158 -r1.159
--- a/ChangeLog	7 Jun 2004 19:54:12 -0000	1.158
+++ b/ChangeLog	9 Jun 2004 18:11:59 -0000	1.159
@@ -1,3 +1,29 @@
+2004-06-09  Joe Shaw  <joeshaw at novell.com>
+
+	Fix some refcounting issues
+
+	* hald/linux/block_class_device.c: Unref the device after we add
+	it to the TDL.
+	(disc_add_to_gdl): Removed; it's functionally equivalent to
+	device_move_from_tdl_to_gdl() in common.c.
+	(disc_remove_from_gdl): Disconnect the signal handlers before
+	removing from the TDL (and thus finalizing).
+	(detect_media): Unref the child after adding it to the TDL.
+	Replace signal handler for "callouts_finished".
+
+	* hald/linux/bus_device.c (bus_device_visit): Unref device after
+	adding it to the TDL.
+	(bus_device_got_parent): Don't unref after removing from the TDL.
+
+	* hald/linux/class_device.c (class_device_visit): Unref device
+	after adding it to TDL.
+	(class_device_got_parent_device, class_device_got_sysdevice,
+	class_device_got_device_file, class_device_final): Don't unref
+	after removing from the TDL.
+
+	* hald/linux/osspec.c (osspec_probe): Unref the fakeroot device
+	after adding it to GDL.
+
 2004-06-07  Joe Shaw  <joeshaw at novell.com>
 
 	* doc/TODO: Add an item about capability matching in FDI files.





More information about the hal-commit mailing list