hal/hald/linux pci_bus_device.c,1.7,1.8

David Zeuthen david at freedesktop.org
Fri Oct 8 11:49:33 PDT 2004


Update of /cvs/hal/hal/hald/linux
In directory gabe:/tmp/cvs-serv1204/hald/linux

Modified Files:
	pci_bus_device.c 
Log Message:
2004-10-08  David Zeuthen  <david at fubar.dk>

	* hald/linux/pci_bus_device.c (pci_ids_load): The {pci, usb} id
	database read functions never close the file descriptors.  bad.
	Fixed in attached patch. Patch from Sjoerd Simons <sjoerd at luon.net>.



Index: pci_bus_device.c
===================================================================
RCS file: /cvs/hal/hal/hald/linux/pci_bus_device.c,v
retrieving revision 1.7
retrieving revision 1.8
diff -u -d -r1.7 -r1.8
--- pci_bus_device.c	5 Jul 2004 18:21:07 -0000	1.7
+++ pci_bus_device.c	8 Oct 2004 18:49:30 -0000	1.8
@@ -302,9 +302,11 @@
 		HAL_ERROR (("Error loading PCI database file\n"));
 		free (pci_ids);
 		pci_ids = NULL;
+		fclose(fp);
 		return FALSE;
 	}
 
+	fclose(fp);
 	return TRUE;
 }
 




More information about the hal-commit mailing list