hal/hald callout.c,1.15.2.1,1.15.2.2

Joe Shaw joeshaw at novell.com
Tue Jan 11 10:05:45 PST 2005


Hey David,


> 2005-01-11  David Zeuthen  <davidz at redhat.com>
> 
>         * hald/callout.c: Fix some craziness adding an idle handler for
>         detecting when callouts complete - fixes bug on my new AMD64
>         system with device add/remove prior to completion of callouts -
>         one visible effect was that fstab-sync was crashing since it
>         couldn't retrieve the block.device device as the device was
>         removed prior to the completion of the callout
> 
> 2005-01-11  David Zeuthen  <davidz at redhat.com>
> 
> 	* hald/callout.c: Simplify a lot more by demanding that callouts
> 	are run sequentially - which they are anyway since everything is
> 	serialized. Make a mental note to review and stress test this in
> 	the morning.

Are you sure this is the right thing to do?  The original code, IIRC,
asynchronously forked off the callouts and then handled reaping them in
an idle handler so that if a callout hung forever it wouldn't wedge the
daemon.  Don't these changes revert that behavior?

Joe





More information about the hal-commit mailing list