hal: Branch 'master'
danny.kukawka at web.de
Mon Aug 27 10:08:13 PDT 2007
On Montag, 27. August 2007, David Zeuthen wrote:
> On Mon, 2007-08-27 at 18:29 +0200, Danny Kukawka wrote:
> > Mean this HAL don't work with older PolicyKit than PK HEAD? (not good!)
> Correct. Is it a problem? There's a bunch of fixes for PK you probably
> want to pull in anyway.
> > The renaming of the actions (s/hal-power-set-powersave/
> > org.freedesktop.hal.power-management.set-powersave/) force also all other
> > tools to change their code to get the information (as e.g. KPowersave,
> > g-p-m or powersaved and other which lookup the policy before call
> > something), this is IMO not the best idea within the RC for 0.5.10 and
> > would blow up the complexity of the tools if they have to support more
> > HAL versions than >= 0.5.10., or not?
> Keep in mind that you get the action name as part of the exception
> detail so you only need to know the action name for the rather oddball
> cases where the caller checks himself to e.g. decide to put a lock icon
> next to the button. I doubt anyone actually does this yet?
Yes, you get a exception. But this is not what you want in each case. For
powermanagemant you want e.g. don't show a action as s2ram/s2disk to the
user if it isn't allowed for this special user. For this you need to know the
name of the policy/action. KPowersave and also powersaved e.g. check the
policies at startup and from time to time (e.g. if the session state change)
to disable/enablee.g. s2ram or change the brightness e.g. in the applet menu.
And this would now work any longer.
IMO this change is at least suboptimal within RC status of HAL.
P.S. Do you have the time to review/approve patches on the HAL ML in the next
days?! Would help a lot!
More information about the hal-commit