hal: Branch 'master'

[Danny Kukawka]

Hi,

IMO it would be more useful to remove the following lines from the macro, I 
think we don't need them really:

else                                                            \
        fprintf (stderr,                                        \
                 "%s %d : INFO: called LIBHAL_FREE_DBUS_ERROR " \
                 "but dbusError was not set.\n",                \
                 __FILE__, __LINE__);                           \

Danny

On Monday 19 February 2007 09:29, David Zeuthen wrote:
>  tools/hal-storage-closetray.c |    8 ++++++--
>  tools/hal-storage-eject.c     |    8 ++++++--
>  tools/hal-storage-mount.c     |   16 ++++++++++++----
>  tools/hal-storage-unmount.c   |    8 ++++++--
>  4 files changed, 30 insertions(+), 10 deletions(-)
>
> New commits:
> diff-tree a7b41e73c214fa95a8ca2ab1805de5558251f599 (from
> e94e5d6bbe489a1269d0e2a5152a1a1f167c7674) Author: David Zeuthen
> <davidz at redhat.com>
> Date:   Mon Feb 19 03:27:03 2007 -0500
>
>     clean up some dangerous use of the LIBHAL_FREE_DBUS_ERROR macro
>
>     The problem is that it prints out to stderr and it broke this code
>
>      if (libhal_device_get_property_bool (hal_ctx, udi, "volume.ignore",
> &error) || dbus_error_is_set (&error)) {
>              LIBHAL_FREE_DBUS_ERROR (&error);
>              permission_denied_volume_ignore (device);
>      }
>
>     when volume.ignore was set to true.