PolicyKit: Branch 'master'

David Zeuthen david at kemper.freedesktop.org
Wed Oct 21 10:14:04 PDT 2009


 src/polkitagent/polkitagenthelper.c |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit f5e0b55b12cb2bec6548747ecb009311d2397ad7
Author: Andreas Sandberg <andreas at sandberg.pp.se>
Date:   Wed Oct 21 13:09:51 2009 -0400

    Bug 24235 – polkit-agent-helper may call pam_end with a stale pam handle
    
    polkit-agent-helper calls pam_end on pam_h without setting pam_h to
    NULL. This causes the error handler to call pam_end on the stale
    handler if the send_dbus_message procedure fails, which in turn
    generates a SIGSEGV.
    
    Signed-off-by: David Zeuthen <davidz at redhat.com>

diff --git a/src/polkitagent/polkitagenthelper.c b/src/polkitagent/polkitagenthelper.c
index e7af888..cca86db 100644
--- a/src/polkitagent/polkitagenthelper.c
+++ b/src/polkitagent/polkitagenthelper.c
@@ -171,6 +171,7 @@ main (int argc, char *argv[])
 #endif /* PAH_DEBUG */
 
   pam_end (pam_h, rc);
+  pam_h = NULL;
 
 #ifdef PAH_DEBUG
   fprintf (stderr, "polkit-agent-helper-1: sending D-Bus message to PolicyKit daemon\n");


More information about the hal-commit mailing list