PolicyKit: Branch 'master'

David Zeuthen david at kemper.freedesktop.org
Mon Mar 14 10:35:43 PDT 2011


 src/polkitagent/polkitagenthelper-pam.c |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit bd8e8eaf320d6a9a30361f0523d3a032e56e6143
Author: David Zeuthen <davidz at redhat.com>
Date:   Mon Mar 14 14:34:45 2011 -0300

    Don't show diagnostic messages intended for the administrator to the end user
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=644737#c6 for discussion.
    
    Signed-off-by: David Zeuthen <davidz at redhat.com>

diff --git a/src/polkitagent/polkitagenthelper-pam.c b/src/polkitagent/polkitagenthelper-pam.c
index 61fed4d..f777829 100644
--- a/src/polkitagent/polkitagenthelper-pam.c
+++ b/src/polkitagent/polkitagenthelper-pam.c
@@ -151,7 +151,6 @@ main (int argc, char *argv[])
       const char *err;
       err = pam_strerror (pam_h, rc);
       fprintf (stderr, "polkit-agent-helper-1: pam_authenticate failed: %s\n", err);
-      send_to_helper ("PAM_ERROR_MSG ", err);
       goto error;
     }
 
@@ -162,7 +161,6 @@ main (int argc, char *argv[])
       const char *err;
       err = pam_strerror (pam_h, rc);
       fprintf (stderr, "polkit-agent-helper-1: pam_acct_mgmt failed: %s\n", err);
-      send_to_helper ("PAM_ERROR_MSG ", err);
       goto error;
     }
 
@@ -173,7 +171,6 @@ main (int argc, char *argv[])
       const char *err;
       err = pam_strerror (pam_h, rc);
       fprintf (stderr, "polkit-agent-helper-1: pam_get_item failed: %s\n", err);
-      send_to_helper ("PAM_ERROR_MSG ", err);
       goto error;
     }
 
@@ -181,7 +178,6 @@ main (int argc, char *argv[])
     {
       fprintf (stderr, "polkit-agent-helper-1: Tried to auth user '%s' but we got auth for user '%s' instead",
                user_to_auth, (const char *) authed_user);
-      send_to_helper ("PAM_ERROR_MSG ", "Authenticated the wrong user");
       goto error;
     }
 


More information about the hal-commit mailing list