[patch] Missing endianness converting in probe_vfat
sjoerd at luon.net
Tue Sep 14 05:37:27 PDT 2004
On Tue, Sep 14, 2004 at 02:11:51PM +0200, David Zeuthen wrote:
> On Fri, 2004-09-10 at 22:00 +0200, Sjoerd Simons wrote:
> > Hi,
> > It seems that probe_vfat is missing some endianness converting in
> > probe_vfat. This showed up on my powerbook, where hal didn't find the
> > label of a memory stick (it thought it was fat32 while it was fat16).
> > Attached patch fixes this.
> I just reverted this one
> > - next_sect_off = (next - 2) * vs->sectors_per_cluster;
> > + next_sect_off = (next - 2) * le16_to_cpu(vs-
> > >sectors_per_cluster);
> as vs->sectors_per_cluster is a 8 bit quantity and it broke it for me on
> my Powerbook on a FAT32 partition.
Your right. /me pulls out the brown paper bag..
Isn't it interesting that the same people who laugh at science fiction
listen to weather forecasts and economists?
-- Kelvin Throop III
hal mailing list
hal at freedesktop.org
More information about the Hal