[PATCH] command line options for hald-addon-acpi

[Timo Hoenig]

Hi,

On Tue, 2005-08-02 at 11:56 +0100, Richard Hughes wrote:

> On Tue, 2005-08-02 at 12:53 +0200, Timo Hoenig wrote:
> > I don't see the benefit of having this as an configure/compile time
> > option.  Please clarify.
> 
> Well, how would we specify the acpi event source from the command line?
> acpi-addon is launched internally by hald - so we would have to change
> the command line to add the new arguments inside hald.

I can only see callouts to  hal-addon-acpi  with information provided by
10-power-mgmt-policy.fdi  ...

> Unless this option is set by an FDI file, which might make most sense,
> if we /have/ to get rid of the fallback code.

... which should specify the option how to gather ACPI events.

> How could a race occur with the current scheme? Sorry if I'm being a bit
> thick.

      * acpid is running, dispatching events via its socket
      * process A is running, using acpid socket to receive ACPI events
      * process B is running, using acpid socket to receive ACPI events
      * acpid dies or gets restarted
      * race between A and B if they both fallback on
        reading  /proc/acpi/event  directly.  

At this point no process will be able to receive ACPI events but the one
which won the race because  /proc/acpi/event  can only be read by a
single process at once.

Simply think of  hald  being Process A or B.

> Richard.

See you,

   Timo

_______________________________________________
hal mailing list
hal at lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/hal