Fix for another ACPI segfault

[Richard Hughes]

On Mon, 2005-08-22 at 14:02 +0200, Martin Pitt wrote:
> Hi!
> 
> We just found another segfault in acpi.c. reporting_unit must be
> checked for NULL before strcmp()'ing it. This was already done in
> 
>   http://cvs.freedesktop.org/hal/hal/hald/linux2/acpi.c?r1=1.25&r2=1.26
> 
> for battery_refresh_poll(), but the fix is missing in
> battery_refresh().
> 
> The patch is only a workaround, the check should be a little more
> elegant. However, that requires to move some code around, so I didn't
> do it on my own.

How's this for a more complete solution?

Something like this should be fixed before 0.5.4.

Richard.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-diff-2005-08-22-16-34-33.patch
Type: text/x-patch
Size: 5240 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20050822/065eac52/hal-diff-2005-08-22-16-34-33-0001.bin