[PATCH] lshal - The next generation
drzeus-list at drzeus.cx
Sun Nov 6 08:53:42 PST 2005
Richard Hughes wrote:
> (sorry for the delay...)
> static void usage (int argc, char *argv)
> Why are we printing to stderr? We appear to be using stderr to output
> all the screen output, which I appreciate the original lshal did. Should
> this not be stdout?
I don't know what reason David had for using stderr in the first place.
So he'll have to answer this one. :)
> Also, should the version check not be done with "-v" rather than "-V"?
-v is usually used for verbose and -V for version.
> print_props() and print_property() are very similar, can we not share
> the common code in another function?
> Some lines are very long, and should probably be split.
> I'm going thru the patch bit by bit at the moment. Do you want to do the
> corrections now, or I could apply the patch as is, and we can work from
> CVS to do the corrections.
These seem to be issues that were present before the patch aswell. So I
would suggest adding fixes as seperate patches. Try to keep the
changelog a bit sane at least. :)
More information about the hal