hald caught in infinite loop while scanning directory

[Martin Pitt]

Hi hal developers!

I just got an interesting hal bug in Ubuntu:

  https://bugzilla.ubuntu.com/show_bug.cgi?id=18293

----------- snip -----------
Starting /etc/dbus-1/event.d/20hal causes an infinite loop, when
scanning the
directory
/usr/share/hal/fdi due to the processing of dot entries (strace shows:
stat64("/usr/share/hal/fdi/preprobe/././././././././././././././././././././
[...] ).

The patch below excludes all dot files and directories.

BTW: According to the scandir manpage, scandir is not POSIX conform.
You might consider replacing it with an appropriate function.
----------- snip -----------

The Bug report also includes a proposed patch which might be improved
a little bit, but looks sane so far.

However, I never saw hald lock up on traversing the current directory
"." at this point. Maybe this is file system specific?

Thanks,

Martin

-- 
Martin Pitt        http://www.piware.de
Ubuntu Developer   http://www.ubuntu.com
Debian Developer   http://www.debian.org

In a world without walls and fences, who needs Windows and Gates?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.freedesktop.org/archives/hal/attachments/20051024/7af13beb/attachment-0001.pgp