hal not parsing netlink messages properly

Kay Sievers kay.sievers at vrfy.org
Sun Oct 30 17:47:15 PST 2005


On Sun, Oct 30, 2005 at 02:28:20PM -0500, Jon Nettleton wrote:
> On Sun, 2005-10-30 at 09:31 -0500, Jon Nettleton wrote:
> > On 10/29/05, Kay Sievers <kay.sievers at vrfy.org> wrote:
> >         > In the debug output there should have been 5 drives
> >         mounted.  You can 
> >         > see only 3 were mounted.  The last two having a message
> >         length of
> >         > 44bytes, which equals two "mount@/block/sdc/sdc1" with the
> >         null
> >         > terminators.
> >         ...
> >         
> >         > 17:46:34.920 [I] osspec.c :243: total_read=22
> >         buf='mount@/block/sda/sda1'
> >         > 17:46:35.084 [I] osspec.c:243: total_read=44
> >         buf='mount@/block/sdc/sdc1'
> >         
> >         Good catch! This is definitely broken. The whole read loop
> >         with the total_read
> >         logic in netlink_detection_data_ready() should be removed
> >         completely. 
> >         
> >         Care to test it and send a patch? Otherwise let me know I can
> >         do it.
> > 
> > Is it as easy as the attached patch?  This seems to work for me.

Yes, looks good.

Thanks,
Kay


More information about the hal mailing list