HAL ported to FreeBSD

Bastien Nocera hadess at hadess.net
Sat Apr 29 08:39:37 PDT 2006


On Sat, 2006-04-29 at 11:27 +0100, Richard Hughes wrote:
> This looks wrong I think:
> 
> -if [ ${value} -lt 0 ] || [ ${value} -ge
> $HAL_PROP_LAPTOP_PANEL_NUM_LEVELS ]; then
> +if [ ${value} -lt 0 ] || [ ${value} -gt
> $HAL_PROP_LAPTOP_PANEL_NUM_LEVELS ]; then
> 
> NUM_LEVELS can be 15, where valid values are 0-14 -- the comment may
> have to be updated I think.
> 
> ------------------------------------
> And then there is this:
> 
> -               dbus-send --system --print-reply
> --dest=org.freedesktop.Hal \
> +               dbus-send --system --dest=org.freedesktop.Hal \
>                           $device org.freedesktop.Hal.Device.Rescan

Those 2 actually look like regressions from the current CVS. I certainly
know the one at the top is, as I fixed it earlier this week.

-- 
Bastien Nocera <hadess at hadess.net> 



More information about the hal mailing list