[PATCH] remove shared.h for addons/prober

Danny Kukawka danny.kukawka at web.de
Mon Aug 21 06:09:55 PDT 2006


Hi,

now the new version of my patch to remove hald/linux2/probing/shared.h. This 
are the major changes:

* removed shared.h and switched addons and prober to use with logger.[c,h] 
  the same functions and format as the hal daemon.
* split off powermanagement related code from util.c/h to a new file 
  util_pm.[c,h].
* added a new file util_helper.[c,h] to collect functions drop_privileges() 
  and hal_set_proc_title*().
* removed unused function strdup_valid_utf8() from probe-storage.c and 
  updated hal_util_strdup_valid_utf8() to do the same as strdup_valid_utf8() 
  before.
* fixed compiler warning in ids.c (use now *_ids_free() functions instead of 
  call free() directly without checks).
* fixed compiler warning in addon-macbookpro-backlight.c (added '#if 0' around 
  unused function)

Please review.

Danny

 a/hald/linux2/probing/shared.h                    |  174 ------------
 b/hald/Makefile.am                                |    4
 b/hald/hald.c                                     |   37 --
 b/hald/linux2/acpi.c                              |    1
 b/hald/linux2/addons/Makefile.am                  |   57 ++--
 b/hald/linux2/addons/addon-acpi-buttons-toshiba.c |   23 -
 b/hald/linux2/addons/addon-acpi.c                 |   32 +-
 b/hald/linux2/addons/addon-hid-ups.c              |    9
 b/hald/linux2/addons/addon-keyboard.c             |    6
 b/hald/linux2/addons/addon-macbookpro-backlight.c |   29 +-
 b/hald/linux2/addons/addon-pmu.c                  |   15 -
 b/hald/linux2/addons/addon-storage.c              |   51 +--
 b/hald/linux2/addons/addon-usb-csr.c              |   47 +--
 b/hald/linux2/apm.c                               |    1
 b/hald/linux2/ids.c                               |   69 ++--
 b/hald/linux2/pmu.c                               |    1
 b/hald/linux2/probing/Makefile.am                 |   16 -
 b/hald/linux2/probing/probe-input.c               |   27 -
 b/hald/linux2/probing/probe-pc-floppy.c           |   16 -
 b/hald/linux2/probing/probe-printer.c             |   24 +
 b/hald/linux2/probing/probe-serial.c              |   23 +
 b/hald/linux2/probing/probe-smbios.c              |   15 -
 b/hald/linux2/probing/probe-storage.c             |   68 +---
 b/hald/linux2/probing/probe-volume.c              |   84 +++---
 b/hald/logger.c                                   |  106 ++++++-
 b/hald/logger.h                                   |    4
 b/hald/util.c                                     |  170 ------------
 b/hald/util.h                                     |    5
 b/hald/util_helper.c                              |  143 ++++++++++
 b/hald/util_helper.h                              |   33 ++
 b/hald/util_pm.c                                  |  194 ++++++++++++++
 b/hald/util_pm.h                                  |   35 ++
 32 files changed, 814 insertions(+), 705 deletions(-)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: hal-replace_shared_h_for_helper_v2.diff
Type: text/x-diff
Size: 95562 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/hal/attachments/20060821/237a7481/hal-replace_shared_h_for_helper_v2-0001.bin


More information about the hal mailing list