[PATCH][RFC] FDI mmap optimization

[Danny Kukawka]

On Wednesday 13 December 2006 16:54, Sergey Lapin wrote:
> Hi,
> please see attached patch, it frees a few kbs of heap on my setup
> (embedded ARM device) and reduces memory fragmentation.

How much bring the patch? Any statistics?

Anyway, on the first lock at the patch I would say this part is not the best 
idea:
 +       if((tmpdir = getenv("TMPDIR")) == NULL) {
 +           tmpdir = "/tmp";
 +       }
 +       cachename = g_strconcat(tmpdir, "/fdi_cache", NULL);

IMO hal should create such a file better e.g. under /var/run/hal/ or /var/tmp

Danny