[PATCH] Re: probe-serial.c does not work on /dev/ttyACM0

[David Zeuthen]

On Wed, 2006-02-22 at 17:47 +0100, Danny Kukawka wrote:
> On Thursday 16 February 2006 21:45, Kay Sievers wrote:
> > Hi Pierre,
> > did you test the serial prober with anything but plain old serial
> > ports? I seems to fail with serial USB devices, common in mobile
> > phones:
> >    open("/dev/ttyACM0", O_RDONLY|O_NONBLOCK|O_LARGEFILE) = 3
> >    ioctl(3, TIOCGSERIAL, 0xbff5029c) = -1 EINVAL (Invalid argument)
> 
> I checked this and discussed this here Hannes Reinecke. Only ttyS* devices 
> support TIOCGSERIAL - all other tty-devices as e.g. ttyACM* and ttyUSB* does 
> not support the command. 
> 
> See attached patch. I fixed serial_get_prober - now the serial prober is only 
> called for ttyS* devices.
> 
> Please review.

Ugh, this is not really the right way to do this.... but OK to commit it
if you add a big "FIXME TODO" note that we shouldn't rely on the name of
the device file....

Thanks,
David