[PATCH, RFC] Add support for keyboard hotkeys

[Matthew Garrett]

On Tue, Jan 31, 2006 at 09:50:37AM +0000, Richard Hughes wrote:

> (side note, did the kernel guys allow your acpi patch to toshiba_acpi?)

Waiting for upstream to push it.

> Sweet, but I see the comment:
> 
> /* FIXME - find the keyboard device */

Ah, sorry - that's fixed, but the comment got left behind.
 
> does this mean the ButtonPressed condition comes from the keyboard or
> some other object?

It comes from the keyboard.

> I have hibernate and suspend keys on my USB keyboard.

What keycode does the hibernate key generate? showkeys on the console 
should tell you.

> Surely we need to launch the addon for each keyboard from an fdi file?

Yup.

> Also adding capability "button" so that applications such as g-p-m can
> monitor this UDI as a "button device"

Yeah, that's the bit I was unsure about. Since it doesn't add 
button.type to the keyboard, should button be listed as a capability? 

g-p-m will need a light patch to support getting the button type from 
the details rather than the object, but that's written already - just 
want to wait to see what the response to this is...

> Should probably have addon-keyboard.c throughout the file...

Sure.

-- 
Matthew Garrett | mjg59 at srcf.ucam.org