[PATCH] libvolume_id fixes for solaris

David Zeuthen david at fubar.dk
Tue Mar 7 08:41:45 PST 2006

On Tue, 2006-03-07 at 16:09 +0100, Kay Sievers wrote:
> > +#ifndef sun
> >  	id->type = "vfat";
> > +#else
> > +	id->type = "pcfs";
> > +#endif
> > +#ifndef sun
> >  	id->type = "iso9660";
> > +#else
> > +	id->type = "hsfs";
> > +#endif
> Hmm, the whole goal of HAL is to abstract that system specific information
> to applications. Are you really sure you want to do it that way and
> patch all the stuff in the upper stack too?

That's an interesting question.

>  (I'm sure no app will recognize
> an iPod formatted with "pcfs" :)) Anyway, you better do that "translation"
> in the Solaris code then, if you really want to do it. :)

Maybe the app is just broken if it looks for the file system name? It
should just look for volume.fsusage='filesystem' and rely on e.g.
gnome-mount etc. or whatever to do the right instead?

However, at least now gnome-mount currently has some hard coded default
mount options for what file system to use but that is subject to change
once it reads stuff from gconf, see


for details.

I just wonder what will break if fs XYZ means something to Solaris and
something else to Linux. Then we get to have conditionals in
20-storage-methods.fdi file at least :-)

Maybe it would be better to just adopt the Linux file system names;
Artem, what do you think? Something to think about.


More information about the hal mailing list